[patch] EXPORTED_SYMBOL_FILE support for cmake

Nico Weber thakis at chromium.org
Sat Dec 28 15:28:00 PST 2013


Since I won't have access to a windows or linux box until monday, this
addresses a FIXME and blocks deadstripping for the cmake build, I'll land
this for post-commit review and hope that the bots will help me sort things
out. (I tested the non-darwin branches on my os x box by temporarily
changing the conditionals, they seem to do what they're supposed to do.)


On Fri, Dec 27, 2013 at 10:08 PM, Nico Weber <thakis at chromium.org> wrote:

> Oh, looks like lto had half an implementation for Windows :-) This removes
> the Windows-specific code, since the general code should cover this (but
> Windows is as I said completely untested).
>
>
> On Fri, Dec 27, 2013 at 10:05 PM, Nico Weber <thakis at chromium.org> wrote:
>
>> Hi,
>>
>> while trying to port the dead code stripping patch (r198087) to cmake, I
>> noticed that the cmake build has no real support for EXPORTED_SYMBOL_FILE –
>> libclang in clang had half an implementation for Darwin with a FIXME for
>> other platforms, tools/gold had half an implementation for BFD ld…
>>
>> This patch tries to add real support – CMakeLists.txt just need to set
>> LLVM_EXPORTED_SYMBOL_FILE and things should Just Work.
>>
>> I've only tested this on OS X, and I don't have a ton of cmake
>> experience. Please review, and / or patch this in and build and let me know
>> how it goes (especially on linux or windows).
>>
>> Nico
>>
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20131228/f5e8e685/attachment.html>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: llvm-cmake-export.patch
Type: application/octet-stream
Size: 9084 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20131228/f5e8e685/attachment.obj>


More information about the llvm-commits mailing list