[PATCH] ARM IAS: improve .eabi_attribute handling

Logan Chien tzuhsiang.chien at gmail.com
Sat Dec 28 11:01:12 PST 2013



================
Comment at: lib/Target/ARM/MCTargetDesc/ARMBuildAttrs.cpp:63
@@ +62,3 @@
+  { ARMBuildAttrs::Virtualization_use, "Tag_Virtualization_use" },
+  { ARMBuildAttrs::MPextension_use_old, "Tag_MPextension_use_old" },
+
----------------
IMO, we should not parse Tag_MPextension_use_old for two reasons: (1) This value is deprecated (2) There is no existing usage of this tag name.


http://llvm-reviews.chandlerc.com/D2484



More information about the llvm-commits mailing list