[PATCH] ARM IAS: handle errors more appropriately

[Logan Chien]

  LGTM.


================
Comment at: lib/Target/ARM/AsmParser/ARMAsmParser.cpp:8212
@@ -8189,3 +8211,3 @@
     Note(FnStartLoc, "previous .fnstart starts here");
-    return true;
+    return false;
   }
----------------
Renato Golin wrote:
> This one looks like an intentional True, which hints that the others were too. I don't remember why they all return true, it could be just left over from an early refactor that didn't go deep enough.
IIRC, I wrote this "return true" because I thought that I should return true whenever there is some parsing error.  After reading the comments in lib/MC/MCParser/AsmParser.cpp (line:1335), it seems that I was wrong.


http://llvm-reviews.chandlerc.com/D2483