[lld] r198102 - [PECOFF] Use std::set to store export symbol descriptors.

[Rui Ueyama]

On Sat, Dec 28, 2013 at 5:35 PM, Chandler Carruth <chandlerc at google.com>wrote:

>
> On Sat, Dec 28, 2013 at 3:11 AM, Rui Ueyama <ruiu at google.com> wrote:
>
>> [PECOFF] Use std::set to store export symbol descriptors.
>>
>> Each export symbol descriptor has unique name attribute, so std::set is
>> better container than std::vector for it.
>>
>
> Really? Better than a sorted and uniqued vector? I find this very
> surprising. std::set is almost useless slow.
>
>  Maybe you could use some of the more tuned LLVM datastructures?
> http://llvm.org/docs/ProgrammersManual.html#ds-set
>

Thank you for the pointer. This code does not have to be fast, so I thought
that std::set is convenient for this use case and fast enough. The
intention of this change is to remove a data member from the class to
simplify it.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20131228/2714661f/attachment.html>