[PATCH] ARM IAS: handle errors more appropriately

Saleem Abdulrasool compnerd at compnerd.org
Fri Dec 27 19:45:10 PST 2013


Hi logan, rengolin,

Directive parsers must return false if the target assembler is interested in
handling the directive.  The Error member function returns true always.  Using
the 'return Error()' pattern would incorrectly indicate to the general parser
that the target was not interested in the directive, when in reality it simply
encountered a badly formed directive or some other error.  This corrects the
behaviour to ensure that the parser behaves appropriately.


http://llvm-reviews.chandlerc.com/D2483

Files:
  lib/Target/ARM/AsmParser/ARMAsmParser.cpp
-------------- next part --------------
A non-text attachment was scrubbed...
Name: D2483.1.patch
Type: text/x-patch
Size: 16525 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20131227/92c39c07/attachment.bin>


More information about the llvm-commits mailing list