[llvm] r198069 - Use two variables here rather than reusing (and abusing) one. This is
Chandler Carruth
chandlerc at gmail.com
Thu Dec 26 20:44:35 PST 2013
Author: chandlerc
Date: Thu Dec 26 22:44:35 2013
New Revision: 198069
URL: http://llvm.org/viewvc/llvm-project?rev=198069&view=rev
Log:
Use two variables here rather than reusing (and abusing) one. This is
much more clear to me. I meant to make this change before committing the
original patch, but forgot to merge it in. Sorry.
Modified:
llvm/trunk/lib/Support/LineIterator.cpp
Modified: llvm/trunk/lib/Support/LineIterator.cpp
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Support/LineIterator.cpp?rev=198069&r1=198068&r2=198069&view=diff
==============================================================================
--- llvm/trunk/lib/Support/LineIterator.cpp (original)
+++ llvm/trunk/lib/Support/LineIterator.cpp Thu Dec 26 22:44:35 2013
@@ -29,15 +29,14 @@ void line_iterator::advance() {
const char *Pos = CurrentLine.end();
assert(Pos == Buffer->getBufferStart() || *Pos == '\n' || *Pos == '\0');
- size_t Length = 0;
if (CommentMarker == '\0') {
// If we're not stripping comments, this is simpler.
- while (Pos[Length] == '\n')
- ++Length;
- Pos += Length;
- LineNumber += Length;
- Length = 0;
+ size_t Blanks = 0;
+ while (Pos[Blanks] == '\n')
+ ++Blanks;
+ Pos += Blanks;
+ LineNumber += Blanks;
} else {
// Skip comments and count line numbers, which is a bit more complex.
for (;;) {
@@ -60,6 +59,7 @@ void line_iterator::advance() {
}
// Measure the line.
+ size_t Length = 0;
do {
++Length;
} while (Pos[Length] != '\0' && Pos[Length] != '\n');
More information about the llvm-commits
mailing list