[PATCH] Move X86DisassemblerDecoderCommon.h to public includes

Chandler Carruth chandlerc at google.com
Thu Dec 26 11:56:08 PST 2013


On Thu, Dec 26, 2013 at 1:14 PM, Reid Kleckner <rnk at google.com> wrote:

>   I don't think moving to include/llvm/TableGen is the right way to go.
>  It's not like the X86 disassembler links against a tablegen library.  The
> only correct layering without adding new libraries is moving it to
> include/llvm/Support, since both llvm-tblgen and the x86 target link
> against Support.  I don't really like that arrangement, but we already have
> these kind of enums-and-types-only headers like ELF.h and COFF.h in Support.


My question is -- why does *tablegen* need this header, rather than it
simply generating code that uses the header? I suspect the real problem is
that the header contains information which should really be in a .td file
and thus an input to the tablegen backend.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20131226/08e730fb/attachment.html>


More information about the llvm-commits mailing list