[llvm] r197997 - gold-plugin.cpp: Use form of <plugin-api.h>, since it is external header.

[Nick Lewycky]

On 12/25/2013 08:06 AM, NAKAMURA Takumi wrote:
> I supposed -I (w/o -I-) could control also search path in <***.h>.
> Both autoconf and cmake are using -I (w/o -I-).
>
> My intention is to distinguish in-tree header and external header with
> the form, "foo.h" or <bar.h>.
> I didn't think, then, my change would cause sideeffects.
> I will follow to revert this if anything went wrong.

Never mind, I must be going crazy. -I affects both <> and "", your 
change should be totally fine. Sorry!

Nick

>
> 2013/12/26 Nick Lewycky <nicholas at mxc.ca>:
>> On 12/24/2013 06:24 PM, NAKAMURA Takumi wrote:
>>>
>>> Author: chapuni
>>> Date: Tue Dec 24 20:24:38 2013
>>> New Revision: 197997
>>>
>>> URL: http://llvm.org/viewvc/llvm-project?rev=197997&view=rev
>>> Log:
>>> gold-plugin.cpp: Use form of <plugin-api.h>, since it is external header.
>>
>>
>> External yes, but a system header? Does the path in configure
>> --with-binutils-include=path get passed in with -I or -isystem? And similar
>> question for cmake, however that's configured?
>>
>> Nick
>>
>>
>>>
>>> Modified:
>>>       llvm/trunk/tools/gold/gold-plugin.cpp
>>>
>>> Modified: llvm/trunk/tools/gold/gold-plugin.cpp
>>> URL:
>>> http://llvm.org/viewvc/llvm-project/llvm/trunk/tools/gold/gold-plugin.cpp?rev=197997&r1=197996&r2=197997&view=diff
>>>
>>> ==============================================================================
>>> --- llvm/trunk/tools/gold/gold-plugin.cpp (original)
>>> +++ llvm/trunk/tools/gold/gold-plugin.cpp Tue Dec 24 20:24:38 2013
>>> @@ -13,7 +13,7 @@
>>>
>>> //===----------------------------------------------------------------------===//
>>>
>>>    #include "llvm/Config/config.h" // plugin-api.h requires HAVE_STDINT_H
>>> -#include "plugin-api.h"
>>> +#include <plugin-api.h>
>>>    #include "llvm-c/lto.h"
>>>    #include "llvm/ADT/StringSet.h"
>>>    #include "llvm/ADT/OwningPtr.h"
>>>
>>>
>>> _______________________________________________
>>> llvm-commits mailing list
>>> llvm-commits at cs.uiuc.edu
>>> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits
>>>
>>
>> _______________________________________________
>> llvm-commits mailing list
>> llvm-commits at cs.uiuc.edu
>> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits
>