[PATCH] tsan: remove in_rtl counter

Dmitry Vyukov dvyukov at google.com
Tue Dec 24 04:09:38 PST 2013


Hi kcc, samsonov, glider, eugenis,

This is intended to address the following problem.
Episodically we see CHECK-failures when recursive interceptors call back into user code. Effectively we are not "in_rtl" at this point, but it's very complicated and fragile to properly maintain in_rtl property. Instead get rid of it. It was used mostly for sanity CHECKs, which basically never uncover real problems.
Instead introduce ignore_interceptors flag, which is used in very few narrow places to disable recursive interceptors (e.g. during runtime initialization).

http://llvm-reviews.chandlerc.com/D2469

Files:
  go/tsan_go.cc
  lit_tests/malloc_hook.cc
  Makefile.old
  check_memcpy.sh
  rtl/tsan_platform_linux.cc
  rtl/tsan_mutexset.h
  rtl/tsan_rtl_mutex.cc
  rtl/tsan_mman.cc
  rtl/tsan_interface_ann.cc
  rtl/tsan_rtl.cc
  rtl/tsan_interface_java.cc
  rtl/tsan_rtl.h
  rtl/tsan_vector.h
  rtl/tsan_interceptors.cc
  rtl/tsan_rtl_thread.cc
  rtl/tsan_interface_atomic.cc
  rtl/tsan_rtl_report.cc
  tests/unit/tsan_vector_test.cc
  tests/unit/tsan_stack_test.cc
  tests/unit/tsan_mman_test.cc
  tests/unit/tsan_clock_test.cc
  tests/unit/tsan_flags_test.cc
  tests/unit/tsan_sync_test.cc
-------------- next part --------------
A non-text attachment was scrubbed...
Name: D2469.1.patch
Type: text/x-patch
Size: 32538 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20131224/1d962b17/attachment.bin>


More information about the llvm-commits mailing list