[PATCH] [AArch64 NEON] Fix a pattern match failure with NEON_VDUP

Jiangning Liu liujiangning1 at gmail.com
Mon Dec 23 22:46:36 PST 2013


The patch LGTM, except the following two things,

1) Need one more test for f64->v1f64
2) the last chunk of change seems unnecessary.

2013/12/18 Kevin Qin <kevinqindev at gmail.com>

> @@ -2110,4 +2123,4 @@
>  declare void @llvm.arm.neon.vst4lane.v2i32(i8*, <2 x i32>, <2 x i32>, <2
> x i32>, <2 x i32>, i32, i32)
>  declare void @llvm.arm.neon.vst4lane.v1i64(i8*, <1 x i64>, <1 x i64>, <1
> x i64>, <1 x i64>, i32, i32)
>  declare void @llvm.arm.neon.vst4lane.v2f32(i8*, <2 x float>, <2 x float>,
> <2 x float>, <2 x float>, i32, i32)
> -declare void @llvm.arm.neon.vst4lane.v1f64(i8*, <1 x double>, <1 x
> double>, <1 x double>, <1 x double>, i32, i32)
> \ No newline at end of file
> +declare void @llvm.arm.neon.vst4lane.v1f64(i8*, <1 x double>, <1 x
> double>, <1 x double>, <1 x double>, i32, i32)
>
>
I'm OK to upstream if those two minor issues can be fixed.

Thanks,
-Jiangning


-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20131224/181fe261/attachment.html>


More information about the llvm-commits mailing list