[PATCH] Change how MachOLinkingContext initializes defaults
Nick Kledzik
kledzik at apple.com
Fri Dec 20 17:52:24 PST 2013
committed in r197851.
-Nick
On Dec 6, 2013, at 10:38 PM, Joe Ranieri <joe at alacatialabs.com> wrote:
> On Mon, Dec 2, 2013 at 7:12 PM, Nick Kledzik <kledzik at apple.com> wrote:
>> Joe,
>>
>> It is a little odd to have some setXXX() methods be called before initialize() and some after. I’d rather get rid of:
>> setOS()
>> setArch()
>> setOutputFileType()
>>
>> And instead have just:
>> configure(HeaderFileType type, OS os, StringRef minOSVersion);
>> which sets those values then does what your initialize() function does.
>
> Fixed.
>
> -- Joe Ranieri
> <macholinkingcontext_configure2.diff>
More information about the llvm-commits
mailing list