[PATCH] [prototype] Adding line table debug information to LLVM on Windows

[dblaikie at gmail.com]

If you don't need null values, you could have <null, ""> be the empty key
and <"", null> be the tombstone, or something like that.

On Fri Dec 20 2013 at 11:50:20 AM, Timur Iskhodzhanov <timurrrr at google.com>
wrote:

>
>
> ================
> Comment at: include/llvm/ADT/DenseMapInfo.h:136
> @@ +135,3 @@
> +  static inline StringRef getEmptyKey() { return StringRef("emptykey"); }
> +  static inline StringRef getTombstoneKey() { return
> StringRef("tombstone!"); }
> +  static unsigned getHashValue(const StringRef &Val) {
> ----------------
> Rafael Ávila de Espíndola wrote:
> > This is way too specific to be in this header. "emptykey" and
> "tombstone!" are valid keys.
> Agreed, but not sure how to proceed.
>
> Can you recommend a better way to create a `DenseMap<pair<StringRef,
> StringRef>, X>` ?
>
>
> http://llvm-reviews.chandlerc.com/D2232
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20131220/7df2f640/attachment.html>