[PATCH v3 1/1] Set RPATH of installed libs and binaries

Artyom Skrobov Artyom.Skrobov at arm.com
Fri Dec 20 08:29:35 PST 2013


Hello Rafael, Jan,

I think CMAKE_INSTALL_RPATH must not be set when it's already set via the
command line.

Do you not mind me applying the following patch on top of yours?

--- a/CMakeLists.txt
+++ b/CMakeLists.txt
@@ -411,7 +411,9 @@ set( CMAKE_RUNTIME_OUTPUT_DIRECTORY
${LLVM_TOOLS_BINARY_DIR} )
 set( CMAKE_LIBRARY_OUTPUT_DIRECTORY ${LLVM_BINARY_DIR}/lib )
 set( CMAKE_ARCHIVE_OUTPUT_DIRECTORY ${LLVM_BINARY_DIR}/lib )
 
-set( CMAKE_INSTALL_RPATH "\$ORIGIN/../lib")
+if( NOT DEFINED CMAKE_INSTALL_RPATH )
+  set( CMAKE_INSTALL_RPATH "\$ORIGIN/../lib")
+endif( NOT DEFINED CMAKE_INSTALL_RPATH )
 
 set(CMAKE_INCLUDE_CURRENT_DIR ON)




> Committed as r197743.
>
> Thanks!
>
> On 19 December 2013 18:04, Jan Vesely <jan.vesely at rutgers.edu> wrote:
>> v2: Use $ORIGIN relative path
>> v3: Always set the RPAHT variable, let CMAKE_SKIP_INSTALL_RPATH decide
whether
>> it's used.
>>
>> Based on:
>> http://www.cmake.org/Wiki/CMake_RPATH_handling#Recommendations
>>
>> Signed-off-by: Jan Vesely <jan.vesely at rutgers.edu>
>> ---
>>
>> Hi,
>>
>> this is the final one-liner patch. I don't have commit access so feel
free
>> to push it.
>>
>> regards,
>> Jan
>>
>>  CMakeLists.txt | 2 ++
>>  1 file changed, 2 insertions(+)
>>
>> diff --git a/CMakeLists.txt b/CMakeLists.txt
>> index 4674338..cf0faa7 100644
>> --- a/CMakeLists.txt
>> +++ b/CMakeLists.txt
>> @@ -411,6 +411,8 @@ set( CMAKE_RUNTIME_OUTPUT_DIRECTORY
${LLVM_TOOLS_BINARY_DIR} )
>>  set( CMAKE_LIBRARY_OUTPUT_DIRECTORY ${LLVM_BINARY_DIR}/lib )
>>  set( CMAKE_ARCHIVE_OUTPUT_DIRECTORY ${LLVM_BINARY_DIR}/lib )
>>
>> +set( CMAKE_INSTALL_RPATH "\$ORIGIN/../lib")
>> +
>>  set(CMAKE_INCLUDE_CURRENT_DIR ON)
>>
>>  include_directories( ${LLVM_INCLUDE_DIR} ${LLVM_MAIN_INCLUDE_DIR})
>> --
>> 1.8.3.1








More information about the llvm-commits mailing list