[PATCH v2 1/1] Add RPATH if not installing to system dir

[Rafael Espíndola]

ccing the list.

On 19 December 2013 10:55, Rafael Espíndola <rafael.espindola at gmail.com> wrote:
> On 19 December 2013 10:15, Jan Vesely <jan.vesely at rutgers.edu> wrote:
>> From: Jan Vesely <jan.vesely at cs.rutgers.edu>
>>
>> v2: Use $ORIGIN relative path
>>
>> Based on:
>> http://www.cmake.org/Wiki/CMake_RPATH_handling#CMake_and_the_RPATH
>>
>> Signed-off-by: Jan Vesely <jan.vesely at rutgers.edu>
>> ---
>> Hi,
>>
>> this patch  uses the $ORIGIN idea. It still checks whether the target dir is
>> among system lib dirs. Another approach would be to add $ORIGIN/../lib rpath
>> unconditionally, and let CMAKE_SKIP_INSTALL_RPATH decide if it's used.
>
> I would prefer the unconditional option as that matches the
> configure+make behavior.
>
> I assume that with that the patch reduces to the attached one liner!
>
> The patch fixes the issue on Linux, so LGTM. Unfortunately OS X will
> still be broken.
>
> Cheers,
> Rafael