[llvm] r197638 - Make cosmetic changes as part of Mips internal post commit review of

[Reed Kotler]

You have to discuss this with Daniel Sanders who is the Mips maintainer and requestor of post commit
reviews.

We are using phabricator for the post commit review and there is a bug filed in our local
bugzilla.

Perhaps the work flow should be different. It does not matter much to me.

Reed

________________________________
From: Eric Christopher [echristo at gmail.com]
Sent: Wednesday, December 18, 2013 4:50 PM
To: Reed Kotler; llvm-commits at cs.uiuc.edu
Subject: [llvm] r197638 - Make cosmetic changes as part of Mips internal post commit review of

Why not just have everyone reply to your original commit?

-eric

On Wed Dec 18 2013 at 4:49:16 PM, Reed Kotler <rkotler at mips.com<mailto:rkotler at mips.com>> wrote:
Author: rkotler
Date: Wed Dec 18 18:43:08 2013
New Revision: 197638

URL: http://llvm.org/viewvc/llvm-project?rev=197638&view=rev
Log:
Make cosmetic changes as part of Mips internal post commit review of
patch r196331.


Modified:
    llvm/trunk/lib/Target/Mips/MipsConstantIslandPass.cpp

Modified: llvm/trunk/lib/Target/Mips/MipsConstantIslandPass.cpp
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Target/Mips/MipsConstantIslandPass.cpp?rev=197638&r1=197637&r2=197638&view=diff
==============================================================================
--- llvm/trunk/lib/Target/Mips/MipsConstantIslandPass.cpp (original)
+++ llvm/trunk/lib/Target/Mips/MipsConstantIslandPass.cpp Wed Dec 18 18:43:08 2013
@@ -1625,7 +1625,7 @@ MipsConstantIslands::fixupConditionalBr(
   MachineBasicBlock *MBB = MI->getParent();
   MachineInstr *BMI = &MBB->back();
   bool NeedSplit = (BMI != MI) || !BBHasFallthrough(MBB);
-  unsigned OppositeBranchOpcode=TII->getOppositeBranchOpc(Opcode);
+  unsigned OppositeBranchOpcode = TII->getOppositeBranchOpc(Opcode);

   ++NumCBrFixed;
   if (BMI != MI) {
@@ -1674,9 +1674,9 @@ MipsConstantIslands::fixupConditionalBr(
     BuildMI(MBB, DebugLoc(), TII->get(OppositeBranchOpcode))
            .addReg(MI->getOperand(0).getReg())
            .addMBB(NextBB);
-  }
-  else { BuildMI(MBB, DebugLoc(), TII->get(OppositeBranchOpcode))
-        .addMBB(NextBB);
+  } else {
+    BuildMI(MBB, DebugLoc(), TII->get(OppositeBranchOpcode))
+           .addMBB(NextBB);
   }
   Br.MI = &MBB->back();
   BBInfo[MBB->getNumber()].Size += TII->GetInstSizeInBytes(&MBB->back());


_______________________________________________
llvm-commits mailing list
llvm-commits at cs.uiuc.edu<mailto:llvm-commits at cs.uiuc.edu>
http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits
English »

Afrikaans

Albanian

Arabic

Armenian

Azerbaijani

Basque

Bengali

Belarusian

Bulgarian

Catalan

Chinese (Simp)

Chinese (Trad)

Croatian

Czech

Danish

Dutch

English

Esperanto

Estonian

Filipino

Finnish

French

Galician

Georgian

German

Greek

Gujarati

Haitian Creole

Hebrew

Hindi

Hungarian

Icelandic

Indonesian

Irish

Italian

Japanese

Kannada

Korean

Lao

Latin

Latvian

Lithuanian

Macedonian

Malay

Maltese

Norwegian

Persian

Polish

Portuguese

Romanian

Russian

Serbian

Slovak

Slovenian

Spanish

Swahili

Swedish

Tamil

Telugu

Thai

Turkish

Ukrainian

Urdu

Vietnamese

Welsh

Yiddish



        <chrome-extension://noaijdpnepcgjemiklgfkcfbkokogabh/history.html>


Feedback<chrome-extension://noaijdpnepcgjemiklgfkcfbkokogabh/feedback.html> : History<chrome-extension://noaijdpnepcgjemiklgfkcfbkokogabh/history.html> : Options<chrome-extension://noaijdpnepcgjemiklgfkcfbkokogabh/options-bbl.html>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20131219/f9e6e457/attachment.html>