[PATCH] Teach the llvm-readobj COFF dumper to dump debug line tables from object files
Eric Christopher
echristo at gmail.com
Wed Dec 18 13:36:17 PST 2013
Not so fond of the formatting, but seems at least reasonable.
================
Comment at: tools/llvm-readobj/COFFDumper.cpp:669
@@ +668,3 @@
+ W.printHex("Magic", Magic);
+ if (Magic != 4) {
+ error(object_error::parse_failed);
----------------
4? An enum maybe or something else?
================
Comment at: tools/llvm-readobj/COFFDumper.cpp:694
@@ +693,3 @@
+ switch (SubSectionType) {
+ case 0xF2: {
+ // F2 is a PC to file:line table. Some data to parse this subsection is
----------------
Same here with F2, F3, F4...
================
Comment at: tools/llvm-readobj/COFFDumper.cpp:787
@@ +786,3 @@
+ StringTable.data()[FilenameOffsetInF3 - 1] != '\0') {
+ // Each string in an F3 subsection should be preceded by a null
+ // character.
----------------
Preceded? Awesome.
http://llvm-reviews.chandlerc.com/D2425
More information about the llvm-commits
mailing list