[PATCH] Change how MachOLinkingContext initializes defaults

Joe Ranieri joe at alacatialabs.com
Tue Dec 17 18:36:36 PST 2013


On Sat, Dec 7, 2013 at 1:38 AM, Joe Ranieri <joe at alacatialabs.com> wrote:
> On Mon, Dec 2, 2013 at 7:12 PM, Nick Kledzik <kledzik at apple.com> wrote:
>> Joe,
>>
>> It is a little odd to have some setXXX() methods be called before initialize() and some after.  I’d rather get rid of:
>>   setOS()
>>   setArch()
>>   setOutputFileType()
>>
>> And instead have just:
>>   configure(HeaderFileType type, OS os, StringRef minOSVersion);
>> which sets those values then does what your initialize() function does.
>
> Fixed.
>
> -- Joe Ranieri

Ping.

-- Joe Ranieri




More information about the llvm-commits mailing list