[patch] Remove the 's' DataLayout specification

Rafael EspĂ­ndola rafael.espindola at gmail.com
Tue Dec 17 15:16:51 PST 2013


During the years there have been some attempts at figuring out how to
align byval arguments. A look at the commit log suggests that they
were

* Use the ABI alignment.
* When that was not sufficient for x86-64, I added the 's'
specification to DataLayout.
* When that was not sufficient Evan added the virtual getByValTypeAlignment.
* When even that was not sufficient, we just got the FE to add the
alignment to the byval.

This patch is just a simple cleanup that removes my first attempt at
fixing the problem. I also added an AArch64 implementation of
getByValTypeAlignment to make sure this patch is a nop. I also left
the 's' parsing for backward compatibility.

Cheers,
Rafael
-------------- next part --------------
A non-text attachment was scrubbed...
Name: t.patch
Type: application/octet-stream
Size: 6238 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20131217/cdd9708e/attachment.obj>


More information about the llvm-commits mailing list