[PATCH] [prototype] Adding line table debug information to LLVM on Windows

[Timur Iskhodzhanov]

  Addressed Reid's comments.

  > +  typedef DenseMap<std::pair<const char*, const char*>, char *>
  > +      DirAndFilenameToFilepathMapTy;
  > ----------------
  > Is this specialized to use string comparison or will it use pointer comparison?
  > If Dir and Filename are uniqued in the IR pointer comparison could be OK.

  I *think* they are uniqued and null-terminated in the IR.
  However, both conditions look very subtle, so I've decided to use pair<StringRef,StringRef> instead.
  This requires defining a specialization for DenseMapInfo<StringRef>, which required adding two extra includes to densemapinfo.h.
  Alternative suggestions are welcome!

  Will try to split the patch now.

Hi echristo, rnk, dblaikie,

http://llvm-reviews.chandlerc.com/D2232

CHANGE SINCE LAST DIFF
  http://llvm-reviews.chandlerc.com/D2232?vs=6126&id=6141#toc

Files:
  include/llvm/ADT/DenseMapInfo.h
  include/llvm/MC/MCAssembler.h
  include/llvm/MC/MCObjectFileInfo.h
  include/llvm/MC/MCStreamer.h
  include/llvm/Support/DebugLoc.h
  lib/CodeGen/AsmPrinter/AsmPrinter.cpp
  lib/CodeGen/AsmPrinter/CMakeLists.txt
  lib/CodeGen/AsmPrinter/DwarfDebug.cpp
  lib/CodeGen/AsmPrinter/WinCodeViewLineTables.cpp
  lib/CodeGen/AsmPrinter/WinCodeViewLineTables.h
  lib/IR/DebugLoc.cpp
  lib/MC/MCAsmStreamer.cpp
  lib/MC/MCAssembler.cpp
  lib/MC/MCObjectFileInfo.cpp
  lib/MC/MCStreamer.cpp
  lib/MC/WinCOFFStreamer.cpp
  lib/Target/X86/MCTargetDesc/X86WinCOFFObjectWriter.cpp
  test/DebugInfo/X86/CodeView/asm.ll
  test/DebugInfo/X86/CodeView/multifile.ll
  test/DebugInfo/X86/CodeView/multifunction.ll
  test/DebugInfo/X86/CodeView/simple.ll
  tools/llvm-readobj/COFFDumper.cpp
  tools/llvm-readobj/llvm-readobj.cpp
  tools/llvm-readobj/llvm-readobj.h
-------------- next part --------------
A non-text attachment was scrubbed...
Name: D2232.8.patch
Type: text/x-patch
Size: 73098 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20131217/438ec445/attachment.bin>