[PATCH] AsmParser: add support for .end directive

David Peixotto dpeixott at codeaurora.org
Mon Dec 16 13:58:36 PST 2013


On 12/16/2013 12:11 PM, Renato Golin wrote:
> On 16 December 2013 18:24, David Peixotto <dpeixott at codeaurora.org
> <mailto:dpeixott at codeaurora.org>> wrote:
>
>     My main question is how does this directive interact with .include'd
>     files. If we have .end in a file that is being processed because of
>     a .include will it stop processing everything, or only that file. I
>     think gas will stop processing everything, even the original file.
>
>
> Would be good to make sure this is correct, as it does sound a bit
> harsh. It's also not what the ARM assembler does [1], not that it
> matters much, but it looks saner than dropping everything altogether.

Yes the arm assembler has a different (and I agree more sane) behavior. 
One difference there is that the END directive is required in arm 
assembly syntax.

I wanted to bring up this issue so that whatever behavior we have is an 
intentional choice in the patch.


> [1]
> http://infocenter.arm.com/help/index.jsp?topic=/com.arm.doc.dui0473j/dom1361290008253.html



More information about the llvm-commits mailing list