[PATCH] [prototype] Adding line table debug information to LLVM on Windows

[Reid Kleckner]

  Cool, I like how the dumper works.  IMO keeping it in readobj is fine.


================
Comment at: lib/CodeGen/AsmPrinter/WinCodeViewLineTables.cpp:162
@@ +161,3 @@
+
+    // PC-to-linenumber LUT:
+    MCSymbol *FileSegmentEnd = 0;
----------------
I'd rather spell out "lookup table"

================
Comment at: lib/CodeGen/AsmPrinter/WinCodeViewLineTables.cpp:181
@@ +180,3 @@
+
+        // Number of PC records in the LUT.
+        size_t SegmentLength = FilenameSegmentLengths[J];
----------------
ditto

================
Comment at: test/DebugInfo/X86/CodeView/multifile.ll:7
@@ +6,3 @@
+; D:\input.c:
+;  1 void g();
+;  2
----------------
For future reference, you can clean up the IR a bit by declaring g void:
  void g(void);

And then the variadic function type bitcasts in the IR will go away.  No need to go back and change the IR for this.


http://llvm-reviews.chandlerc.com/D2232