[PATCH] Add warning capabilities in LLVM (backend part), Take 2
Quentin Colombet
qcolombet at apple.com
Mon Dec 16 09:41:02 PST 2013
Hi Tobias,
On Dec 14, 2013, at 1:20 AM, Tobias Grosser <tobias at grosser.es> wrote:
> On 12/12/2013 06:40 PM, Quentin Colombet wrote:
>> - Suppress DiagnosticInfoOther class.
>> - Add DK_FirstPluginKind and the related getNextAvailablePluginKind function.
>>
>> Hi dblaikie, rengolin, chandlerc, echristo,
>>
>> http://llvm-reviews.chandlerc.com/D2376
>
> Hi Quentin,
>
> I just wanted to say that I did a simple test with this in Polly (as a plugin), and it seems to work as expected.
I am glad it worked for you!
>
> I found one minor issue:
>
> - The return type of getNextAvailablePluginDiagnosticKind should be
> DiagnosticKind, not int.
Well, technically, the returned type is not DiagnosticKind, as the returned value is not a valid value in the statically known DiagnosticKind enum.
>
> I am looking forward to get this in.
Me too :).
Cheers,
-Quentin
>
> Cheers,
> Tobias
>
>
More information about the llvm-commits
mailing list