[llvm] r197119 - Check for null pointer before dereferencing. A careless typo on my part.

[David Blaikie]

Do you have a test case? I assume this actually bit you at some point
in some particular test case...

On Wed, Dec 11, 2013 at 6:41 PM, Reed Kotler <rkotler at mips.com> wrote:
> Author: rkotler
> Date: Wed Dec 11 20:41:11 2013
> New Revision: 197119
>
> URL: http://llvm.org/viewvc/llvm-project?rev=197119&view=rev
> Log:
> Check for null pointer before dereferencing. A careless typo on my part.
> I don't know why this did not show up earlier. This code has been
> around for ages.
>
>
> Modified:
>     llvm/trunk/lib/Target/Mips/MipsISelLowering.cpp
>
> Modified: llvm/trunk/lib/Target/Mips/MipsISelLowering.cpp
> URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Target/Mips/MipsISelLowering.cpp?rev=197119&r1=197118&r2=197119&view=diff
> ==============================================================================
> --- llvm/trunk/lib/Target/Mips/MipsISelLowering.cpp (original)
> +++ llvm/trunk/lib/Target/Mips/MipsISelLowering.cpp Wed Dec 11 20:41:11 2013
> @@ -2331,7 +2331,7 @@ getOpndList(SmallVectorImpl<SDValue> &Op
>      if (GlobalAddressSDNode *G = dyn_cast<GlobalAddressSDNode>(CLI.Callee)) {
>        llvm::StringRef Sym = G->getGlobal()->getName();
>        Function *F = G->getGlobal()->getParent()->getFunction(Sym);
> -      if (F->hasFnAttribute("__Mips16RetHelper")) {
> +      if (F && F->hasFnAttribute("__Mips16RetHelper")) {
>          Mask = MipsRegisterInfo::getMips16RetHelperMask();
>        }
>      }
> @@ -3262,7 +3262,7 @@ MipsTargetLowering::MipsCC::SpecialCalli
>      if (GlobalAddressSDNode *G = dyn_cast<GlobalAddressSDNode>(Callee)) {
>        llvm::StringRef Sym = G->getGlobal()->getName();
>        Function *F = G->getGlobal()->getParent()->getFunction(Sym);
> -      if (F->hasFnAttribute("__Mips16RetHelper")) {
> +      if (F && F->hasFnAttribute("__Mips16RetHelper")) {
>          SpecialCallingConv = MipsCC::Mips16RetHelperConv;
>        }
>      }
>
>
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits