[PATCH] [prototype] Adding line table debug information to LLVM on Windows
Timur Iskhodzhanov
timurrrr at google.com
Wed Dec 11 11:16:45 PST 2013
Added a prototype CodeView line table dumper to COFFDumper.cpp
Can you please suggest
- an effective splitting of the whole patch to make it easier to review
- a good way to structure the new code, e.g. is it fine to leave the CV dumper in COFFDumper or should I have a gorilla holding a banana like dwarf-dump works? (e.g. DI structures etc)
- is the simple.ll OBJ32 kind of test enough? or maybe you've meant some other kind of testing using a dumper?
- what tests do we need for the dumper itself?
Hi echristo, rnk,
http://llvm-reviews.chandlerc.com/D2232
CHANGE SINCE LAST DIFF
http://llvm-reviews.chandlerc.com/D2232?vs=5930&id=6037#toc
Files:
include/llvm/MC/MCAssembler.h
include/llvm/MC/MCObjectFileInfo.h
include/llvm/MC/MCStreamer.h
lib/CodeGen/AsmPrinter/AsmPrinter.cpp
lib/CodeGen/AsmPrinter/CMakeLists.txt
lib/CodeGen/AsmPrinter/WinCodeViewLineTables.cpp
lib/CodeGen/AsmPrinter/WinCodeViewLineTables.h
lib/MC/MCAsmStreamer.cpp
lib/MC/MCAssembler.cpp
lib/MC/MCObjectFileInfo.cpp
lib/MC/MCStreamer.cpp
lib/MC/WinCOFFStreamer.cpp
lib/Target/X86/MCTargetDesc/X86WinCOFFObjectWriter.cpp
test/DebugInfo/X86/CodeView/asm.ll
test/DebugInfo/X86/CodeView/multifile.ll
test/DebugInfo/X86/CodeView/multifunction.ll
test/DebugInfo/X86/CodeView/simple.ll
tools/llvm-readobj/COFFDumper.cpp
tools/llvm-readobj/llvm-readobj.cpp
tools/llvm-readobj/llvm-readobj.h
-------------- next part --------------
A non-text attachment was scrubbed...
Name: D2232.4.patch
Type: text/x-patch
Size: 62694 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20131211/506de5cb/attachment.bin>
More information about the llvm-commits
mailing list