[PATCH] Support Android NDK (which has neither futimes nor futimens)
Alp Toker
alp at nuanti.com
Wed Dec 11 07:48:35 PST 2013
On 11/12/2013 15:15, Neil Henning wrote:
> As per the discussion on the llvm-commits mailing list - I've simplified the fix.
>
> I've taken Alp Toker's approach but removed all mention of ANDROID from the patch, instead allowing setLastModificationAndAccessTime to gracefully fail at runtime should a platform not have support for futimes or futimens.
Thanks Neil! Landed in r197045 with the return code changed to the more
appropriate errc::not_supported plus some documentation.
Alp.
> Hi rafael.espindola, chandlerc,
>
> http://llvm-reviews.chandlerc.com/D2357
>
> CHANGE SINCE LAST DIFF
> http://llvm-reviews.chandlerc.com/D2357?vs=5971&id=6024#toc
>
> Files:
> lib/Support/Unix/Path.inc
>
> Index: lib/Support/Unix/Path.inc
> ===================================================================
> --- lib/Support/Unix/Path.inc
> +++ lib/Support/Unix/Path.inc
> @@ -537,7 +537,8 @@
> Times[1] = Times[0];
> if (::futimes(FD, Times))
> #else
> -#error Missing futimes() and futimens()
> +#warning Missing futimes() and futimens()
> + return make_error_code(errc::operation_not_permitted);
> #endif
> return error_code(errno, system_category());
> return error_code::success();
>
>
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits
--
http://www.nuanti.com
the browser experts
More information about the llvm-commits
mailing list