[PATCH] Linking of shared libraries for MIPS little-endian 32-bit target

Shankar Kalpathi Easwaran shankarke at gmail.com
Tue Dec 10 07:24:14 PST 2013


  Apart from the comments above, LGTM.


================
Comment at: lib/ReaderWriter/ELF/Mips/MipsTargetHandler.cpp:106
@@ +105,3 @@
+private:
+  const MipsTargetLayout<Mips32ElELFType> &_layout;
+
----------------
You could use the same function findOutputSection by removing const. 

================
Comment at: lib/ReaderWriter/ELF/DefaultLayout.h:201-207
@@ -200,1 +200,9 @@
 
+  /// \brief Find an output Section given a section name.
+  const MergedSections<ELFT> *findOutputSection(StringRef name) const {
+    auto iter = _mergedSectionMap.find(name);
+    if (iter == _mergedSectionMap.end())
+      return nullptr;
+    return iter->second;
+  }
+
----------------
You may want to remove this duplicate function.


http://llvm-reviews.chandlerc.com/D2156



More information about the llvm-commits mailing list