[PATCH] Add small text file reader facility.
Sean Silva
silvas at purdue.edu
Mon Dec 9 20:38:12 PST 2013
================
Comment at: include/llvm/Support/FileUtilities.h:110
@@ +109,3 @@
+ /// \brief Return true if this iterator is the same as the given one.
+ inline bool operator==(const FileReader &FR) const {
+ return FR.Filename == Filename && FR.FP == FR.FP;
----------------
Do you feel strongly about having all these things explicitly marked inline? The compiler should make a good enough decision here I think to avoid the noise (and it's not like this is super performance-critical anyway).
================
Comment at: include/llvm/Support/FileUtilities.h:166
@@ +165,3 @@
+ size_t Length = 0;
+ const char *start = FP;
+
----------------
http://llvm.org/docs/CodingStandards.html#name-types-functions-variables-and-enumerators-properly
http://llvm-reviews.chandlerc.com/D2294
More information about the llvm-commits
mailing list