[PATCH] Zorg, lld build factory: disable -stdlib=libc++ for GNU builds

[Mikael Lyngvig]

Honestly, I don't know Clang very well so if you say so, I'm okay with it.
 I just know that LLD requires libc++ and libc++abi when using Clang++
according to the documentation on llvm.org.

I've attached a new patch that just gets rid of the -stdlib=libc++:

Index: zorg/buildbot/builders/LLDBuilder.py
===================================================================
--- zorg/buildbot/builders/LLDBuilder.py        (revision 196862)
+++ zorg/buildbot/builders/LLDBuilder.py        (working copy)
@@ -57,10 +57,11 @@
                                haltOnFailure=False,
                                description=["create build dir"],
                                workdir="."))
+
     cmakeCommand = [
         "cmake",
         "-DCMAKE_BUILD_TYPE=Release",
-        "-DCMAKE_CXX_FLAGS=\"-Wall -Werror -std=c++11 -stdlib=libc++
-U__STRICT_ANSI__\"",
+        "-DCMAKE_CXX_FLAGS=\"-Wall -Werror -std=c++11 -U__STRICT_ANSI__\"",
         "../%s" % llvm_srcdir]
     # Note: ShellCommand does not pass the params with special symbols
right.
     # The " ".join is a workaround for this bug.


-- Mikael


2013/12/10 Chandler Carruth <chandlerc at google.com>

>
> On Mon, Dec 9, 2013 at 6:44 PM, Mikael Lyngvig <mikael at lyngvig.org> wrote:
>
>> +
>> +    # Only use -stdlib=libc++ for Clang++, not for GCC.
>> +    stdlib = ""
>> +    if env['CXX'].find('clang++') != -1:
>> +        stdlib = "-stdlib=libc++"
>> +
>>
>
> Why not just remove this entirely and rely on the default -stdlib?
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20131210/939a53b8/attachment.html>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: zorg-stdlib-selection-1.patch
Type: application/octet-stream
Size: 828 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20131210/939a53b8/attachment.obj>