[PATCH] Implement the ldr-pseudo opcode for ARM assembly

[David Peixotto]

Ping

> -----Original Message-----
> From: David Peixotto [mailto:dpeixott at codeaurora.org]
> Sent: Thursday, December 05, 2013 2:39 PM
> To: 'Jim Grosbach'
> Cc: 'Renato Golin'; 'Commit Messages and Patches for LLVM'; 'Tim
> Northover'
> Subject: RE: [PATCH] Implement the ldr-pseudo opcode for ARM assembly
> 
> Ping, Jim any feedback?
> 
> > -----Original Message-----
> > From: David Peixotto [mailto:dpeixott at codeaurora.org]
> > Sent: Wednesday, December 04, 2013 9:58 AM
> > To: 'Tim Northover'
> > Cc: 'Renato Golin'; 'Jim Grosbach'; 'Commit Messages and Patches for
> LLVM'
> > Subject: RE: [PATCH] Implement the ldr-pseudo opcode for ARM assembly
> >
> > > I think it looks reasonable too. I've played around with it and I
> > > can't see anything wrong with the Darwin output.
> > >
> > > One small thing I (well, clang) noticed is that the variable
> > > ConstantPoolCounter is unused.
> >
> > Oops, that was left around from an earlier refactoring. I will clean
> > it up in the final commit.
> >
> > It sounds like everyone so far is ok with the patch. I will wait to
> > get an ok from Jim before committing.