[PATCH] Zorg: getLLDBuildFactory() now takes an optional 'env' parameter

[Dmitri Gribenko]

On Mon, Dec 9, 2013 at 11:34 AM, Mikael Lyngvig <mikael at lyngvig.org> wrote:
> The patch has been updated and I am re-submitting everything I've submitted
> to Galina as well so that it goes through a full peer review.
>
> Phew, thank you a ton for catching that!
>
> As far as the CC and CXX environment variables goes, I did it to retain
> backwards compatibility with the existing three LLD builders:
>
> -                               env={
> -                                    'CXX': "clang++",
> -                                    'C':   "clang"},
> +                               env=merged_env,
>
> So they already got overriden, I have simply made the override overriddable
> :-)  Now you can specify that you want to use ccache in the env argument,
> something you could not do before.  I am also going to use ccache.  I bet
> your lld builds haven't been using ccache, even if you thought they did.

I think they are using ccache, please take a look:

http://lab.llvm.org:8011/builders/llvm-clang-lld-x86_64-ubuntu-13.04/builds/10304/steps/cmake-configure/logs/stdio

Dmitri

-- 
main(i,j){for(i=2;;i++){for(j=2;j<i;j++){if(!(i%j)){j=0;break;}}if
(j){printf("%d\n",i);}}} /*Dmitri Gribenko <gribozavr at gmail.com>*/