[llvm][Patch 3/3] ppc-darwin AsmParser Base implementation.

Iain Sandoe iain at codesourcery.com
Sat Dec 7 05:21:12 PST 2013


Hi Ulrich,

thanks for reviewing!

On 6 Dec 2013, at 13:11, Ulrich Weigand wrote:

> Instead of every call to ParseExpression having to make this
> distinction, wouldn't it be easier to just check for isDarwin
> *inside* of ParseExpression?

To avoid the multiple tests, I've placed a single test inside ParseExpression() which calls out to ParseDawinExpression().  I think the implementations are sufficiently different to warrant keeping the separate routines.

Is the revised version ok for commit?
Iain

-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: ppc-darwin-asm-parser-part3v2-diff.txt
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20131207/dc5ab0d9/attachment.txt>


More information about the llvm-commits mailing list