[PATCH] Fix instcombine's folding of select into phi nodes for ConstantExpr

Justin Bogner mail at justinbogner.com
Fri Dec 6 13:23:55 PST 2013


"Duncan P. N. Exon Smith" <dexonsmith at apple.com> writes:
> On Dec 6, 2013, at 11:20 AM, Justin Bogner <mail at justinbogner.com> wrote:
>
>> How tricky is it to come up with a test case that doesn't rely on us
>> failing to constant fold the icmp here? This one seems a bit fragile.
>
> Thanks for the suggestion.  The test in the updated patch uses
> extern_weak globals in the icmp, which should *not* be constant
> folded.

Much better. Thanks.



More information about the llvm-commits mailing list