[llvm][Patch 2/3] ppc-darwin AsmParser Base implementation.

[Ulrich Weigand]

Iain Sandoe <iain at codesourcery.com> wrote:

> Part 2 Enables parsing of {r,f,v}XX as register identifiers.

+    if(isDarwin()) {

I think coding style is to have a space after "if" (occurs
in a couple of places).

     case AsmToken::Integer:
-      if (getParser().parseAbsoluteExpression(IntVal) ||
+      if(!isDarwin()) {
+        if (getParser().parseAbsoluteExpression(IntVal) ||
           IntVal < 0 || IntVal > 31)
         return Error(S, "invalid register number");
+      } else {
+        return Error(S, "unexpected integer value");
+      }
       break;

Does the Darwin assembler really *prohibit* use of
plain integers to identify registers in addresses?

Otherwise, looks good to me.

Thanks,
Ulrich