[PATCH] [AArch64 NEON]Replace fpimm with fpz32 for floating compare with zero.

Tim Northover t.p.northover at gmail.com
Fri Dec 6 02:49:27 PST 2013


  Hi Kevin,

  I'm glad you're in the area! I was looking at these just yesterday and noticed that the syntax they use for printing is non-canonical. The zero should apparently print as "#0" rather than "#0.0"

  Looks like there was some miscommunication in the code-review when they were committed. You originally suggested an "fpz32short" operand class for them, which printed as "#0" but was otherwise identical to fpz32. That was a good idea, and as I recall the only problem was that it had an unneeded "PrintMethod", but it somehow got dropped from the final patch.

  Cheers.

  Tim.

  (I'm also horrified by that Neon_cmpz: it really shouldn't exist  as a separate AArch64ISD node from Neon_cmp. But we can probably leave that until the two backends are merged).

http://llvm-reviews.chandlerc.com/D2349



More information about the llvm-commits mailing list