Re: [PATCH] apply transformation on Darwin platform: pow(10, x) ―> __exp10(x)

[Yi Jiang]

Thank you guys for the comments. Here is the new patch:
-------------- next part --------------
A non-text attachment was scrubbed...
Name: exp.patch
Type: application/octet-stream
Size: 7024 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20131205/8983b9c6/attachment.obj>
-------------- next part --------------


On Dec 5, 2013, at 8:48 AM, Meador Inge <meadori at codesourcery.com> wrote:

> On 12/05/2013 08:55 AM, Stephen Canon wrote:
> 
>> On Dec 5, 2013, at 1:07 AM, Yi Jiang <yjiang at apple.com> wrote:
>> 
>>> +  // "__exp10" and "__exp10f" is Darwin-specific and would be only avaliable on 
>>> +  // Mac OS/X 10.9 and iOS 7.0 and later.
>>> ...
>>> +; Check pow(10.0, x) -> __exp10(x) on Mac OS/X 10.9+ and iOS 7.0+ .
>> 
>> Typos: “available” and “Mac OS X” (no slash).
>> 
>> This looks fine from a numerics standpoint.  Someone else will need to review the compiler aspects of it.
> 
> There are some 80-column violations in the simplifier additions, but other than
> that the other bits LGTM.
> 
> -- 
> Meador Inge
> CodeSourcery / Mentor Embedded