[PATCH] [prototype] Adding line table debug information to LLVM on Windows

Timur Iskhodzhanov timurrrr at google.com
Thu Dec 5 06:18:15 PST 2013


  I've looked how file/dir handling is done in Clang and I think these strings are always stored/obtained separately.
  I don't think there's a single place in the Clang codebase where they are merged together into a full filepath string.

  I decided to write a dozen of lines in WinCodeViewLineTables.cpp to handle canonicalization of Windows filepaths rather than threading extra info from Clang to IR to LLVM in a cross-platform way...
  After all, we only have one "user" of this data as of now.

  Do you think this's reasonable?

Hi echristo, rnk,

http://llvm-reviews.chandlerc.com/D2232

CHANGE SINCE LAST DIFF
  http://llvm-reviews.chandlerc.com/D2232?vs=5884&id=5930#toc

Files:
  include/llvm/MC/MCAssembler.h
  include/llvm/MC/MCObjectFileInfo.h
  include/llvm/MC/MCStreamer.h
  lib/CodeGen/AsmPrinter/AsmPrinter.cpp
  lib/CodeGen/AsmPrinter/CMakeLists.txt
  lib/CodeGen/AsmPrinter/WinCodeViewLineTables.cpp
  lib/CodeGen/AsmPrinter/WinCodeViewLineTables.h
  lib/MC/MCAsmStreamer.cpp
  lib/MC/MCAssembler.cpp
  lib/MC/MCObjectFileInfo.cpp
  lib/MC/MCStreamer.cpp
  lib/MC/WinCOFFStreamer.cpp
  lib/Target/X86/MCTargetDesc/X86WinCOFFObjectWriter.cpp
  test/DebugInfo/X86/CodeView/asm.ll
  test/DebugInfo/X86/CodeView/multifile.ll
  test/DebugInfo/X86/CodeView/multifunction.ll
  test/DebugInfo/X86/CodeView/simple.ll
-------------- next part --------------
A non-text attachment was scrubbed...
Name: D2232.3.patch
Type: text/x-patch
Size: 56209 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20131205/c39d8241/attachment.bin>


More information about the llvm-commits mailing list