[PATCH] Add support for parsing ARM symbol variants on ELF targets

[David Peixotto]

Committed in r196424, thanks.

> -----Original Message-----
> From: llvm-commits-bounces at cs.uiuc.edu [mailto:llvm-commits-
> bounces at cs.uiuc.edu] On Behalf Of David Peixotto
> Sent: Wednesday, December 04, 2013 10:00 AM
> To: 'Tim Northover'
> Cc: 'llvm-commits'
> Subject: RE: [PATCH] Add support for parsing ARM symbol variants on ELF
> targets
> 
> > Hi David,
> >
> > > I've attached a patch that removes most of the VK_ARM_* types along
> > > with parsing the variants correctly for ARM.
> >
> > Thanks! I love seeing refactoring like this. I've got one comment:
> >
> > +      if (Lexer.isNot(AsmToken::RParen)) {
> > +          return Error(Lexer.getTok().getLoc(), "unexpected token in
> > + variant");
> >
> > I think this error message could be more helpful if it mentions that
> > we expect a closing paren. I'd be happy for you to fix that and commit
> > without posting another patch for review -- I'll take a look at the
> > commit.
> 
> Ok, I will improve the error message and commit. Thanks!
> 
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits