[llvm] r196416 - DwarfDebug: Unconditionalize trivial asm comments
David Blaikie
dblaikie at gmail.com
Wed Dec 4 13:51:05 PST 2013
Author: dblaikie
Date: Wed Dec 4 15:51:05 2013
New Revision: 196416
URL: http://llvm.org/viewvc/llvm-project?rev=196416&view=rev
Log:
DwarfDebug: Unconditionalize trivial asm comments
While we still have a few (~4) non-trivial comments with string
concatenation, etc that should remain conditionalized, these trivial
literal comments can be simplified.
Modified:
llvm/trunk/lib/CodeGen/AsmPrinter/DwarfDebug.cpp
Modified: llvm/trunk/lib/CodeGen/AsmPrinter/DwarfDebug.cpp
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/CodeGen/AsmPrinter/DwarfDebug.cpp?rev=196416&r1=196415&r2=196416&view=diff
==============================================================================
--- llvm/trunk/lib/CodeGen/AsmPrinter/DwarfDebug.cpp (original)
+++ llvm/trunk/lib/CodeGen/AsmPrinter/DwarfDebug.cpp Wed Dec 4 15:51:05 2013
@@ -2128,8 +2128,7 @@ void DwarfDebug::emitDIE(DIE *Die, Array
for (unsigned j = 0, M = Children.size(); j < M; ++j)
emitDIE(Children[j], Abbrevs);
- if (Asm->isVerbose())
- Asm->OutStreamer.AddComment("End Of Children Mark");
+ Asm->OutStreamer.AddComment("End Of Children Mark");
Asm->EmitInt8(0);
}
}
@@ -2484,8 +2483,7 @@ void DwarfDebug::emitDebugPubNames(bool
Asm->EmitInt8(Desc.toBits());
}
- if (Asm->isVerbose())
- Asm->OutStreamer.AddComment("External Name");
+ Asm->OutStreamer.AddComment("External Name");
Asm->OutStreamer.EmitBytes(StringRef(Name, GI->getKeyLength() + 1));
}
@@ -2522,8 +2520,7 @@ void DwarfDebug::emitDebugPubTypes(bool
Asm->OutStreamer.EmitLabel(BeginLabel);
- if (Asm->isVerbose())
- Asm->OutStreamer.AddComment("DWARF Version");
+ Asm->OutStreamer.AddComment("DWARF Version");
Asm->EmitInt16(dwarf::DW_PUBTYPES_VERSION);
Asm->OutStreamer.AddComment("Offset of Compilation Unit Info");
@@ -2544,8 +2541,7 @@ void DwarfDebug::emitDebugPubTypes(bool
const char *Name = GI->getKeyData();
const DIE *Entity = GI->second;
- if (Asm->isVerbose())
- Asm->OutStreamer.AddComment("DIE offset");
+ Asm->OutStreamer.AddComment("DIE offset");
Asm->EmitInt32(Entity->getOffset());
if (GnuStyle) {
@@ -2556,8 +2552,7 @@ void DwarfDebug::emitDebugPubTypes(bool
Asm->EmitInt8(Desc.toBits());
}
- if (Asm->isVerbose())
- Asm->OutStreamer.AddComment("External Name");
+ Asm->OutStreamer.AddComment("External Name");
// Emit the name with a terminating null byte.
Asm->OutStreamer.EmitBytes(StringRef(Name, GI->getKeyLength() + 1));
More information about the llvm-commits
mailing list