[PATCH] Implement the ldr-pseudo opcode for ARM assembly

[Amara Emerson]

Same here.

Jim, is this ok to go in?

Amara

-----Original Message-----
From: llvm-commits-bounces at cs.uiuc.edu
[mailto:llvm-commits-bounces at cs.uiuc.edu] On Behalf Of Tim Northover
Sent: 04 December 2013 16:16
To: David Peixotto
Cc: Commit Messages and Patches for LLVM
Subject: Re: [PATCH] Implement the ldr-pseudo opcode for ARM assembly

> Still waiting for internal approval for phabricator. Would it be ok to
> conduct the review the old-fashioned way for now?

I think it looks reasonable too. I've played around with it and I
can't see anything wrong with the Darwin output.

One small thing I (well, clang) noticed is that the variable
ConstantPoolCounter is unused.

Cheers.

Tim.
_______________________________________________
llvm-commits mailing list
llvm-commits at cs.uiuc.edu
http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits