[PATCH] [sanitizer] Fix log_path behavior with StopTheWorld.

Sergey Matveev earthdok at google.com
Wed Dec 4 04:38:40 PST 2013



================
Comment at: lib/sanitizer_common/sanitizer_common.cc:47
@@ +46,3 @@
+// main process, but has a different PID and thus requires special handling.
+uptr tracer_report_fd_pid = 0;
+
----------------
Alexey Samsonov wrote:
> The naming is now confusing. Can you use smth. like stoptheworld_tracer_pid? Or, assuming you never use the value of this global anyway, can you have a boolean "is_in_stoptheworld_tracer"?
> can you have a boolean "is_in_stoptheworld_tracer"?

No, because the child and the parent will simultaneously be "in tracer" and "not in tracer".


http://llvm-reviews.chandlerc.com/D2306



More information about the llvm-commits mailing list