[PATCH] Pass the non-zero label to __dfsan_nonzero_label

Peter Collingbourne peter at pcc.me.uk
Tue Dec 3 21:23:45 PST 2013



================
Comment at: lib/Transforms/Instrumentation/DataFlowSanitizer.cpp:115
@@ -114,3 +114,3 @@
 
-static cl::opt<bool> ClDebugNonzeroLabels(
-    "dfsan-debug-nonzero-labels",
+static cl::opt<bool> ClLogNonzeroLabels(
+    "dfsan-log-nonzero-labels",
----------------
As discussed offline, the nonzero-label functionality is for ABI debugging purposes only. If we want to create a log of anything that touches labels it would be better to include arithmetic operations, stores etc. and I think that should be turned on with a separate flag.


http://llvm-reviews.chandlerc.com/D2317



More information about the llvm-commits mailing list