[llvm] r196306 - Return true on success in cl::ExpandResponseFiles

[Reid Kleckner]

Author: rnk
Date: Tue Dec  3 13:13:18 2013
New Revision: 196306

URL: http://llvm.org/viewvc/llvm-project?rev=196306&view=rev
Log:
Return true on success in cl::ExpandResponseFiles

This fixes a logic bug pointed out by Juraj Ivancic.

No behavior change because none of the in-tree clients of
cl::ExpandResponseFiles check the return value.  In this case, the
@prefixed arguments are left in the command line.  Downstream command
line processing has the opportunity to emit errors about it, so this
isn't that bad.

Modified:
    llvm/trunk/lib/Support/CommandLine.cpp

Modified: llvm/trunk/lib/Support/CommandLine.cpp
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Support/CommandLine.cpp?rev=196306&r1=196305&r2=196306&view=diff
==============================================================================
--- llvm/trunk/lib/Support/CommandLine.cpp (original)
+++ llvm/trunk/lib/Support/CommandLine.cpp Tue Dec  3 13:13:18 2013
@@ -634,7 +634,7 @@ static bool ExpandResponseFile(const cha
 bool cl::ExpandResponseFiles(StringSaver &Saver, TokenizerCallback Tokenizer,
                              SmallVectorImpl<const char *> &Argv) {
   unsigned RspFiles = 0;
-  bool AllExpanded = false;
+  bool AllExpanded = true;
 
   // Don't cache Argv.size() because it can change.
   for (unsigned I = 0; I != Argv.size(); ) {