[PATCH] Generalize debug info / EH emission in AsmPrinter

[Timur Iskhodzhanov]

  Committed as r196270, thanks for the review!


================
Comment at: include/llvm/CodeGen/AsmPrinter.h:25
@@ -24,2 +24,3 @@
 namespace llvm {
+  class AsmPrinterObserver;
   class BlockAddress;
----------------
Eric Christopher wrote:
> Not a huge fan of observer... maybe worker? Handler? I think I like Handler the most, but naming is hard so if you don't think it sounds better then go ahead :)
OK, Handler it is.

================
Comment at: lib/CodeGen/AsmPrinter/AsmPrinterObserver.h:18
@@ +17,3 @@
+
+#include <stdint.h>
+
----------------
Reid Kleckner wrote:
> Eric Christopher wrote:
> > I think you want Support/DataTypes.h here?
> Fun fact: stdint.h is available since MSVC 2010, so we can use it freely now.  Unfortunately DataTypes.h defines other types as well.  Someone should try untangling it though.
OK, done

================
Comment at: lib/CodeGen/AsmPrinter/DIE.cpp:394
@@ +393,3 @@
+  unsigned DwarfVersion = AP->getDwarfVersion();
+  assert(DwarfVersion && "Expected Dwarf Debug info to be available");
+  if (DwarfVersion == 2)
----------------
Eric Christopher wrote:
> Timur Iskhodzhanov wrote:
> > Eric Christopher wrote:
> > > Let's make this AP->getDwarfDebug() != NULL as you mention above.
> > The reason why I've changed that to getDwarfVersion() is that I removed getDwarfDebug entirely.
> > Do you think I should get it back?
> Nah, I guess it's fine this way, it's just a bit awkward.
OK, brought getDwarfDebug() back and removed getDwarfVersion().


http://llvm-reviews.chandlerc.com/D2222