[PATCH] disabled switching ARM modes in inline asm

Renato Golin renato.golin at linaro.org
Tue Dec 3 00:57:51 PST 2013


  Hi Greg,

  The two problems I mapped from our discussion were:
   1. The compiler must go back to its own state after inline assembly, and err if the user makes it hard.
   2. The compiler must detect changes in inline assembly, and record its own state, to be able to do so.

  Forbidding state change altogether is a first approach on correctness, and I'm fine with this patch as it is. For the future, do you plan on implementing a more fine grained approach?


================
Comment at: include/llvm/MC/MCTargetAsmParser.h:101
@@ +100,3 @@
+  /// ParsingInlineGnuAsm - Are we parsing GAS-syntax inline assembly?
+  bool ParsingInlineGnuAsm;
+
----------------
I don't understand why you need this...


http://llvm-reviews.chandlerc.com/D2255



More information about the llvm-commits mailing list