[PATCH] Generalize debug info / EH emission in AsmPrinter

[Eric Christopher]

  LGTM with the changes I've mentioned.


================
Comment at: lib/CodeGen/AsmPrinter/AsmPrinterObserver.h:18
@@ +17,3 @@
+
+#include <stdint.h>
+
----------------
I think you want Support/DataTypes.h here?

================
Comment at: lib/CodeGen/AsmPrinter/DIE.cpp:394
@@ +393,3 @@
+  unsigned DwarfVersion = AP->getDwarfVersion();
+  assert(DwarfVersion && "Expected Dwarf Debug info to be available");
+  if (DwarfVersion == 2)
----------------
Let's make this AP->getDwarfDebug() != NULL as you mention above.

================
Comment at: include/llvm/CodeGen/AsmPrinter.h:25
@@ -24,2 +24,3 @@
 namespace llvm {
+  class AsmPrinterObserver;
   class BlockAddress;
----------------
Not a huge fan of observer... maybe worker? Handler? I think I like Handler the most, but naming is hard so if you don't think it sounds better then go ahead :)


http://llvm-reviews.chandlerc.com/D2222