[PATCH] [sanitizer] Implement TwoLevelByteMap and use it for the internal allocator on 64-bit.

Kostya Serebryany kcc at google.com
Mon Nov 25 01:47:32 PST 2013


  agree with everything except for the race on counters.


================
Comment at: lib/sanitizer_common/tests/sanitizer_allocator_test.cc:838
@@ +837,3 @@
+  m.TestOnlyInit();
+  TestMapUnmapCallback::map_count = 0;
+  TestMapUnmapCallback::unmap_count = 0;
----------------
Dmitry Vyukov wrote:
> as far as I see, you have a data race on these counters
How? 
map_count is updated under mu_
unmap_count is updated when all threads are joined. 


http://llvm-reviews.chandlerc.com/D2259

BRANCH
  svn

ARCANIST PROJECT
  compiler-rt



More information about the llvm-commits mailing list