[PATCH] Scoped NoAlias Metadata

[Renato Golin]

  I'm looking at the tests now, but apart from some comments below, the code looks good to me.

  Of course, I'd encourage other people to have a look as well, as I'm no expert in AA.


================
Comment at: lib/IR/IRBuilder.cpp:75
@@ -73,3 +74,3 @@
   
   // Set the TBAA info if present.
   if (TBAATag)
----------------
Update this comment

================
Comment at: lib/IR/IRBuilder.cpp:106
@@ -97,3 +105,3 @@
 
   // Set the TBAA Struct info if present.
   if (TBAAStructTag)
----------------
update this comment

================
Comment at: lib/IR/IRBuilder.cpp:133
@@ -117,3 +132,3 @@
   
   // Set the TBAA info if present.
   if (TBAATag)
----------------
update this comment

================
Comment at: lib/Transforms/Utils/InlineFunction.cpp:426
@@ +425,3 @@
+          !isa<AtomicCmpXchgInst>(NI) && !isa<AtomicRMWInst>(NI) &&
+          !isa<MemIntrinsic>(NI))
+        continue;
----------------
Couldn't this be an else on the if block below? It's probably going to evaluate isa<> on each one (at least) anyway.

================
Comment at: lib/Transforms/Utils/InlineFunction.cpp:447
@@ +446,3 @@
+
+      // If we found on pointers, then this instruction is not suitable for
+      // pairing with an instruction to receive aliasing metadata.
----------------
found "no" pointers?


http://llvm-reviews.chandlerc.com/D2194