[LNT] r195506 - By popular demand, when LNT nt fails while running a subprocess command, make sure the error message which is printed has the name of the log file which contains the output of the failing command.

[Chris Matthews]

Sorry about that. It should be fixed now.  I don’t know why my testing script didn’t pick that up.

Chris Matthews
chris.matthews at apple.com

On Nov 22, 2013, at 4:50 PM, Chris Matthews <chris.matthews at apple.com> wrote:

> I will look right now.
> 
> Chris Matthews
> chris.matthews at apple.com
> 
> On Nov 22, 2013, at 4:44 PM, Tobias Grosser <tobias at grosser.es> wrote:
> 
>> On 11/22/2013 11:17 PM, Chris Matthews wrote:
>>> Author: cmatthews
>>> Date: Fri Nov 22 16:17:56 2013
>>> New Revision: 195506
>>> 
>>> URL: http://llvm.org/viewvc/llvm-project?rev=195506&view=rev
>>> Log:
>>> By popular demand, when LNT nt fails while running a subprocess command, make sure the error message which is printed has the name of the log file which contains the output of the failing command.
>>> 
>>> Modified:
>>>     lnt/trunk/lnt/tests/nt.py
>>> 
>>> Modified: lnt/trunk/lnt/tests/nt.py
>>> URL: http://llvm.org/viewvc/llvm-project/lnt/trunk/lnt/tests/nt.py?rev=195506&r1=195505&r2=195506&view=diff
>>> ==============================================================================
>>> --- lnt/trunk/lnt/tests/nt.py (original)
>>> +++ lnt/trunk/lnt/tests/nt.py Fri Nov 22 16:17:56 2013
>>> @@ -600,6 +600,8 @@ def execute_nt_tests(test_log, make_vari
>>>        print >>sys.stderr, '%s: building "nightly tests" with -j%u...' % (
>>>            timestamp(), config.build_threads)
>>>        res = execute_command(test_log, basedir, args, report_dir)
>>> +      if res != 0:
>>> +          print >> sys.std, "Failure while running make build!  See log: %s"%(test_log.name)
>>> 
>>>      # Then 'make report'.
>>>      args = common_args + ['-j', str(config.threads),
>>> @@ -617,6 +619,9 @@ def execute_nt_tests(test_log, make_vari
>>> 
>>>      res = execute_command(test_log, basedir, args, report_dir)
>>> 
>>> +    if res != 0:
>>> +        print >> sys.std, "Failure while running nightly tests!  See log: %s"%(test_log.name)
>> 
>> Does sys.std exist or did you mean sys.stderr?
>> 
>> For me with python 2.7 sys.std does not exist and instead of an error message, the whole lnt crashes. Could you have a look?
>> 
>> Cheers,
>> Tobias
> 

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20131122/032005e4/attachment.html>