[llvm] r195518 - [PM] Remove a FIXME comment that was fixed by my recent refactorings:

Chandler Carruth chandlerc at gmail.com
Fri Nov 22 15:37:55 PST 2013


Author: chandlerc
Date: Fri Nov 22 17:37:54 2013
New Revision: 195518

URL: http://llvm.org/viewvc/llvm-project?rev=195518&view=rev
Log:
[PM] Remove a FIXME comment that was fixed by my recent refactorings:
now the access to the manager is via the proxy that ensures it behaves
correctly.

Modified:
    llvm/trunk/include/llvm/IR/PassManager.h

Modified: llvm/trunk/include/llvm/IR/PassManager.h
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/include/llvm/IR/PassManager.h?rev=195518&r1=195517&r2=195518&view=diff
==============================================================================
--- llvm/trunk/include/llvm/IR/PassManager.h (original)
+++ llvm/trunk/include/llvm/IR/PassManager.h Fri Nov 22 17:37:54 2013
@@ -632,10 +632,6 @@ private:
 /// never use a function analysis manager from within (transitively) a module
 /// pass manager unless your parent module pass has received a proxy result
 /// object for it.
-///
-/// FIXME: It might be really nice to "enforce" this (softly) by making this
-/// proxy the API path to access a function analysis manager within a module
-/// pass.
 class FunctionAnalysisManagerModuleProxy {
 public:
   class Result;





More information about the llvm-commits mailing list