[llvm] r195494 - Debug Info: add a constant for debug info version number.

[Eric Christopher]

On Fri, Nov 22, 2013 at 12:08 PM, Manman Ren <manman.ren at gmail.com> wrote:
>
>
>
> On Fri, Nov 22, 2013 at 11:52 AM, Eric Christopher <echristo at gmail.com>
> wrote:
>>
>> Naming is hard, but I'd rather this not be in the Dwarf file and
>> rather in the IR files since this is entirely an IR thing and not
>> related to any actual dwarf constant at all.
>
>
> Fair point. Any suggestion on where to put the constant?
>

include/llvm/Metadata.h?

-eric

> Manman
>
>>
>>
>> DEBUG_METADATA_VERSION might be a better name.
>>
>> -eric
>>
>> On Fri, Nov 22, 2013 at 11:41 AM, Manman Ren <manman.ren at gmail.com> wrote:
>> > Author: mren
>> > Date: Fri Nov 22 13:41:59 2013
>> > New Revision: 195494
>> >
>> > URL: http://llvm.org/viewvc/llvm-project?rev=195494&view=rev
>> > Log:
>> > Debug Info: add a constant for debug info version number.
>> >
>> > This will be used to output the debug info version number as a module
>> > flag.
>> >
>> > Modified:
>> >     llvm/trunk/include/llvm/Support/Dwarf.h
>> >
>> > Modified: llvm/trunk/include/llvm/Support/Dwarf.h
>> > URL:
>> > http://llvm.org/viewvc/llvm-project/llvm/trunk/include/llvm/Support/Dwarf.h?rev=195494&r1=195493&r2=195494&view=diff
>> >
>> > ==============================================================================
>> > --- llvm/trunk/include/llvm/Support/Dwarf.h (original)
>> > +++ llvm/trunk/include/llvm/Support/Dwarf.h Fri Nov 22 13:41:59 2013
>> > @@ -57,6 +57,7 @@ enum LLVMConstants LLVM_ENUM_INT_TYPE(ui
>> >    DW_TAG_user_base = 0x1000, // Recommended base for user tags.
>> >
>> >    DWARF_VERSION = 4,       // Default dwarf version we output.
>> > +  DEBUG_INFO_VERSION = 1,  // Current debug info version number.
>> >    DW_CIE_VERSION = 1,      // Common frame information version.
>> >    DW_PUBTYPES_VERSION = 2, // Section version number for
>> > .debug_pubtypes.
>> >    DW_PUBNAMES_VERSION = 2, // Section version number for
>> > .debug_pubnames.
>> >
>> >
>> > _______________________________________________
>> > llvm-commits mailing list
>> > llvm-commits at cs.uiuc.edu
>> > http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits
>
>